Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-01-19 13:50:28
Also in:
netdev
On Mon, Jan 18, 2021 at 02:33:29PM -0800, Jakub Kicinski wrote:
On Fri, 15 Jan 2021 12:46:20 +0800 wangyunjian wrote:quoted
From: Yunjian Wang <redacted> Currently the driver doesn't drop a packet which can't be sent by tun (e.g bad packet). In this case, the driver will always process the same packet lead to the tx queue stuck. To fix this issue: 1. in the case of persistent failure (e.g bad packet), the driver can skip this descriptor by ignoring the error. 2. in the case of transient failure (e.g -ENOBUFS, -EAGAIN and -ENOMEM), the driver schedules the worker to try again. Signed-off-by: Yunjian Wang <redacted>Michael, LMK if you want to have a closer look otherwise I'll apply tomorrow.
Thanks for the reminder. Acked. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization