Thread (1 message) 1 message, 1 author, 2020-12-07

Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()

flat view

From: Jason Wang <hidden>
Date: 2020-12-07 05:19:38
Also in: kvm, lkml, netdev

On 2020/12/4 下午4:43, Zhang Changzhong wrote:
quoted hunk
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Zhang Changzhong <redacted>
---
  drivers/vhost/scsi.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 6ff8a5096..4ce9f00 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
  			if (!vhost_vq_is_setup(vq))
  				continue;
  
-			if (vhost_scsi_setup_vq_cmds(vq, vq->num))
+			ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
+			if (ret)
  				goto destroy_vq_cmds;
  		}
  

Acked-by: Jason Wang <redacted>


_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help