Thread (1 message) 1 message, 1 author, 2020-12-07

Re: [RFC PATCH 02/27] vhost: Add device callback in vhost_migration_log

flat view

From: Stefan Hajnoczi <hidden>
Date: 2020-12-07 16:26:41
Also in: kvm, qemu-devel

On Fri, Nov 20, 2020 at 07:50:40PM +0100, Eugenio Pérez wrote:
quoted hunk
This allows code to reuse the logic to not to re-enable or re-disable
migration mechanisms. Code works the same way as before.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 hw/virtio/vhost.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 2bd8cdf893..2adb2718c1 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -862,7 +862,9 @@ err_features:
     return r;
 }
 
-static int vhost_migration_log(MemoryListener *listener, bool enable)
+static int vhost_migration_log(MemoryListener *listener,
+                               bool enable,
+                               int (*device_cb)(struct vhost_dev *, bool))
Please document the argument. What is the callback function supposed to
do ("device_cb" is not descriptive so I'm not sure)?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help