On 18.10.20 14:41, Wei Yang wrote:
On Fri, Oct 16, 2020 at 03:17:06PM +0200, David Hildenbrand wrote:
quoted
On 16.10.20 10:53, Wei Yang wrote:
quoted
On Mon, Oct 12, 2020 at 02:53:14PM +0200, David Hildenbrand wrote:
quoted
Let's rename to "sbs_per_mb" and "sb_size" and move accordingly.
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <redacted>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Signed-off-by: David Hildenbrand <redacted>
One trivial suggestion, could we move this patch close the data structure
movement patch?
I know this would be some work, since you have changed some of the code logic.
This would take you some time to rebase.
You mean after patch #17 ?
Yes
quoted
I guess I can move patch #18 (prereq) a little further up (e.g., after
patch #15). Guess moving it in front of #19 shouldn't be too hard.
Will give it a try - if it takes too much effort, I'll leave it like this.
Not a big deal, while it will make the change more intact to me.
This is a big patch set to me. In case it could be split into two parts, like
bug fix/logic improvement and BBM implementation, that would be more friendly
to review.
I'll most probably keep it as a single series, but reshuffle the patches
into
1. cleanups
2. preparations
3. BBM
That should make things easier to digest. Thanks!
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization