Re: [PATCH v6 02/76] KVM: SVM: Add GHCB definitions
From: Borislav Petkov <bp@alien8.de>
Date: 2020-08-25 11:04:56
Also in:
kvm, lkml
From: Borislav Petkov <bp@alien8.de>
Date: 2020-08-25 11:04:56
Also in:
kvm, lkml
On Tue, Aug 25, 2020 at 11:22:24AM +0200, Joerg Roedel wrote:
I don't think so, if I look at the history of these checks their whole purpose seems to be to alert the developer/maintainer when their size changes and that they might not fit on the stack anymore. But that is taken care of in patch 1.
Why? What's wrong with:
BUILD_BUG_ON(sizeof(struct vmcb_save_area) != VMCB_SAVE_AREA_SIZE);
BUILD_BUG_ON(sizeof(struct vmcb_control_area) != VMCB_CONTROL_AREA_SIZE);
BUILD_BUG_ON(sizeof(struct ghcb) != PAGE_SIZE);
?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization