Re: [PATCH 09/10] block: scsi: sd: use blk_is_valid_logical_block_size
From: Damien Le Moal <hidden>
Date: 2020-07-21 11:25:17
Also in:
linux-block, linux-mmc, linux-scsi, lkml
On 2020/07/21 19:55, Maxim Levitsky wrote:
Use blk_is_valid_logical_block_size instead of hardcoded list
s/hardcoded list/hardcoded checks./
quoted hunk ↗ jump to hunk
Signed-off-by: Maxim Levitsky <redacted> --- drivers/scsi/sd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index d90fefffe31b7..f012e7397b058 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c@@ -2520,10 +2520,7 @@ sd_read_capacity(struct scsi_disk *sdkp, unsigned char *buffer) "assuming 512.\n"); } - if (sector_size != 512 && - sector_size != 1024 && - sector_size != 2048 && - sector_size != 4096) { + if (!blk_is_valid_logical_block_size(sector_size)) { sd_printk(KERN_NOTICE, sdkp, "Unsupported sector size %d.\n", sector_size); /*
With the commit message fixed, looks OK. Reviewed-by: Damien Le Moal <redacted> -- Damien Le Moal Western Digital Research