Re: [PATCH v2 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do_req()
From: Markus Elfring <hidden>
Date: 2020-05-26 07:04:03
Also in:
linux-crypto, lkml, stable
Fix it by sg_next() on calculation of src/dst scatterlist.
Wording adjustment: … by calling the function “sg_next” … …
quoted hunk ↗ jump to hunk
+++ b/drivers/crypto/virtio/virtio_crypto_algs.c@@ -350,13 +350,18 @@ __virtio_crypto_skcipher_do_req(struct virtio_crypto_sym_request *vc_sym_req,
…
src_nents = sg_nents_for_len(req->src, req->cryptlen);
+ if (src_nents < 0) {
+ pr_err("Invalid number of src SG.\n");
+ return src_nents;
+ }
+
dst_nents = sg_nents(req->dst);… I suggest to move the addition of such input parameter validation to a separate update step. Regards, Markus