Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

On 2020/5/13 下午12:42, Zhu, Lingshan wrote:

On 5/13/2020 12:12 PM, Jason Wang wrote:

quoted

On 2020/5/12 下午4:00, Zhu Lingshan wrote:

quoted

This commit move IRQ request and free operations from probe()
to VIRTIO status change handler to comply with VIRTIO spec.

VIRTIO spec 1.1, section 2.1.2 Device Requirements: Device Status Field
The device MUST NOT consume buffers or send any used buffer
notifications to the driver before DRIVER_OK.

This comment needs to be checked as I said previously. It's only 
needed if we're sure ifcvf can generate interrupt before DRIVER_OK.

quoted

Signed-off-by: Zhu Lingshan <redacted>
---
changes from V1:
remove ifcvf_stop_datapath() in status == 0 handler, we don't need 
to do this
twice; handle status == 0 after DRIVER_OK -> !DRIVER_OK handler 
(Jason Wang)

Patch looks good to me, but with this patch ping cannot work on my 
machine. (It works without this patch).

Thanks

This is strange, it works on my machines, let's have a check offline.

Thanks,
BR
Zhu Lingshan

Note that I tested the patch with vhost-vpda.

Thanks.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization