Thread (4 messages) 4 messages, 3 authors, 2020-02-16

Re: [PATCH] virtio_balloon: Fix unused label warning

From: David Hildenbrand <hidden>
Date: 2020-02-10 09:38:23
Also in: lkml

On 10.02.20 10:33, Borislav Petkov wrote:
quoted hunk ↗ jump to hunk
From: Borislav Petkov <redacted>

Fix

  drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’:
  drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_del_vqs’ defined but not used [-Wunused-label]
    963 | out_del_vqs:
        | ^~

The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too.

Signed-off-by: Borislav Petkov <redacted>
Cc: David Hildenbrand <redacted>
---
 drivers/virtio/virtio_balloon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 7bfe365d9372..b6ed5f8bccb1 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -959,9 +959,9 @@ static int virtballoon_probe(struct virtio_device *vdev)
 	iput(vb->vb_dev_info.inode);
 out_kern_unmount:
 	kern_unmount(balloon_mnt);
-#endif
 out_del_vqs:
 	vdev->config->del_vqs(vdev);
+#endif
 out_free_vb:
 	kfree(vb);
 out:
Oh, right, thanks!

Reviewed-by: David Hildenbrand <redacted>

-- 
Thanks,

David / dhildenb
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help