[PATCH RFC v4 11/13] mm/vmscan: Move count_vm_event(DROP_SLAB) into drop_slab()
DORMANTno replies
From: David Hildenbrand <hidden>
Date: 2019-12-12 17:11:35
Subsystem:
filesystems (vfs and infrastructure), memory management, memory management - mglru (multi-gen lru), memory management - reclaim, the rest · Maintainers:
Alexander Viro, Christian Brauner, Andrew Morton, Johannes Weiner, Linus Torvalds
Revision v4 of 5 in this series.
Revisions (5)
- v4 current
- v4
- v1 [diff vs current]
- v3 [diff vs current]
- v4
Possibly related (same subject, not in this thread)
- 2020-02-25 · Re: [PATCH RFC v4 11/13] mm/vmscan: Move count_vm_event(DROP_SLAB) into drop_slab() · Michal Hocko <mhocko@kernel.org>
Let's count within the function itself, so every invocation (of future users) will be counted. Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-fsdevel@vger.kernel.org Signed-off-by: David Hildenbrand <redacted> --- fs/drop_caches.c | 4 +--- mm/vmscan.c | 1 + 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/drop_caches.c b/fs/drop_caches.c
index d31b6c72b476..a042da782fcd 100644
--- a/fs/drop_caches.c
+++ b/fs/drop_caches.c@@ -61,10 +61,8 @@ int drop_caches_sysctl_handler(struct ctl_table *table, int write, iterate_supers(drop_pagecache_sb, NULL); count_vm_event(DROP_PAGECACHE); } - if (sysctl_drop_caches & 2) { + if (sysctl_drop_caches & 2) drop_slab(); - count_vm_event(DROP_SLAB); - } if (!stfu) { pr_info("%s (%d): drop_caches: %d\n", current->comm, task_pid_nr(current),
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 5a6445e86328..c3e53502a84a 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c@@ -726,6 +726,7 @@ void drop_slab(void) for_each_online_node(nid) drop_slab_node(nid); + count_vm_event(DROP_SLAB); } static inline int is_page_cache_freeable(struct page *page)
--
2.23.0