Thread (1 message) flat view 1 message, 1 author, 2019-11-09

Re: [PATCH] vsock/virtio: fix sock refcnt holding during the shutdown

From: David Miller <davem@davemloft.net>
Date: 2019-11-09 20:29:38
Also in: kvm, lkml, netdev

From: Stefano Garzarella <sgarzare@redhat.com>
Date: Fri,  8 Nov 2019 17:08:50 +0100
The "42f5cda5eaf4" commit rightly set SOCK_DONE on peer shutdown,
but there is an issue if we receive the SHUTDOWN(RDWR) while the
virtio_transport_close_timeout() is scheduled.
In this case, when the timeout fires, the SOCK_DONE is already
set and the virtio_transport_close_timeout() will not call
virtio_transport_reset() and virtio_transport_do_close().
This causes that both sockets remain open and will never be released,
preventing the unloading of [virtio|vhost]_transport modules.

This patch fixes this issue, calling virtio_transport_reset() and
virtio_transport_do_close() when we receive the SHUTDOWN(RDWR)
and there is nothing left to read.

Fixes: 42f5cda5eaf4 ("vsock/virtio: set SOCK_DONE on peer shutdown")
Cc: Stephen Barber <redacted>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help