Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 3 Sep 2018 23:11:11 -0400

On Tue, Sep 04, 2018 at 11:08:40AM +0800, Jason Wang wrote:

quoted

On 2018年09月04日 10:22, Michael S. Tsirkin wrote:

quoted

On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote:

quoted

The _IOC_READ flag fits this ioctl request more because this request
actually only writes to, but doesn't read from userspace.
See NOTEs in include/uapi/asm-generic/ioctl.h for more information.

Fixes: 429711aec282 ("vhost: switch to use new message format")
Signed-off-by: Gleb Fotengauer-Malinovskiy <redacted>

Hmm it does make sense, and it's not too late to fix this up.
Jason, what's your take on this? Was _IOW intentional?

My bad, not intentional. And I agree that fixing this is not too late.

So

Acked-by: Jason Wang <redacted>

OK then

Acked-by: Michael S. Tsirkin <mst@redhat.com>

Applied, thanks everyone.