Re: [PATCH 1/2] virtio/s390: avoid race on vcdev->config

On Fri, 21 Sep 2018 17:47:47 -0400
Farhan Ali [off-list ref] wrote:

On 09/21/2018 09:28 AM, Halil Pasic wrote:

quoted

Anyway I'm fine with swapping the old out and your new version in,
if you prefer it that way.

If you do, would you like to have a respin?

Just send me a respin with something that you find useful :) (maybe a
mashup of our descriptions) (while at it, you could also add the
cc:stable, which I agree make sense)

quoted

Regards,
Halil
  

I had been looking into this code recently, and shouldn't vcdev->status 
(function get/set_status functions) also have a lock around it? Or is it 
not possible to have a race condition on vcdev->status?

I don't think so, as status is only a byte.

Thanks
Farhan

quoted

quoted

quoted

Let us protect the shared state using vcdev->lock.

Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
---
  drivers/s390/virtio/virtio_ccw.c | 10 ++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)