Re: [PATCH] drm/bochs: Replace ttm_bo_unref with ttm_bo_put

On Thu, Aug 30, 2018 at 08:14:02AM +0200, Thomas Zimmermann wrote:

Hi Gerd

Am 09.08.2018 um 17:27 schrieb Gerd Hoffmann:

quoted

quoted

diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
index 39cd08416773..c9c7097030ca 100644
--- a/drivers/gpu/drm/bochs/bochs_mm.c
+++ b/drivers/gpu/drm/bochs/bochs_mm.c

@@ -430,7 +430,7 @@ static void bochs_bo_unref(struct bochs_bo **bo)
 		return;
 
 	tbo = &((*bo)->bo);
-	ttm_bo_unref(&tbo);
+	ttm_bo_put(tbo);

fails to build:

  CC [M]  drivers/gpu/drm/bochs/bochs_mm.o
/home/kraxel/projects/linux/drivers/gpu/drm/bochs/bochs_mm.c: In function ‘bochs_bo_unref’:
/home/kraxel/projects/linux/drivers/gpu/drm/bochs/bochs_mm.c:433:2: error: implicit declaration of function ‘ttm_bo_put’ [-Werror=implicit-function-declaration]
  ttm_bo_put(tbo);
  ^
cc1: some warnings being treated as errors

The required interfaces are now available in mainline. [1] I rebuilt to
make sure it compiles.

Besides bochs, [2] the patches for qxl, [3] cirrus, [4] vmwgfx, [5][6]
and virtio [7][8] should now build as well. They still apply cleanly
AFAICT. Let me know if you prefer a new patch set instead.

Yes. builds now.  vmwgfx is not my cup of tea, but I'll pick up the
other ones (and can finally remove them from my patches mailbox) and let
you know in case I run into trouble.

cheers,
  Gerd

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization