Re: [RFC 0/4] Virtio uses DMA API for all devices
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2018-08-06 21:46:34
Possibly related (same subject, not in this thread)
- 2018-09-10 · Re: [RFC 0/4] Virtio uses DMA API for all devices · Gerd Hoffmann <kraxel@redhat.com>
- 2018-09-10 · Re: [RFC 0/4] Virtio uses DMA API for all devices · Christoph Hellwig <hch@infradead.org>
- 2018-08-09 · Re: [RFC 0/4] Virtio uses DMA API for all devices · Christoph Hellwig <hch@infradead.org>
- 2018-08-09 · Re: [RFC 0/4] Virtio uses DMA API for all devices · Benjamin Herrenschmidt <benh@kernel.crashing.org>
- 2018-08-08 · Re: [RFC 0/4] Virtio uses DMA API for all devices · Benjamin Herrenschmidt <benh@kernel.crashing.org>
On Tue, Aug 07, 2018 at 07:26:35AM +1000, Benjamin Herrenschmidt wrote:
On Mon, 2018-08-06 at 23:35 +0300, Michael S. Tsirkin wrote:quoted
quoted
As I said replying to Christoph, we are "leaking" into the interface something here that is really what's the VM is doing to itself, which is to stash its memory away in an inaccessible place. Cheers, Ben.I think Christoph merely objects to the specific implementation. If instead you do something like tweak dev->bus_dma_mask for the virtio device I think he won't object.Well, we don't have "bus_dma_mask" yet ..or you mean dma_mask ? So, something like that would be a possibility, but the problem is that the current virtio (guest side) implementation doesn't honor this when not using dma ops and will not use dma ops if not using iommu, so back to square one.
Well we have the RFC for that - the switch to using DMA ops unconditionally isn't problematic itself IMHO, for now that RFC is blocked by its perfromance overhead for now but Christoph says he's trying to remove that for direct mappings, so we should hopefully be able to get there in X weeks.
quoted hunk ↗ jump to hunk
Christoph seems to be wanting to use a flag in the interface to make the guest use dma_ops which is what I don't understand. What would be needed then would be something along the lines of virtio noticing that dma_mask isn't big enough to cover all of memory (which isn't something generic code can easily do here for various reasons I can elaborate if you want, but that specific test more/less has to be arch specific), and in that case, force itself to use DMA ops routed to swiotlb. I'd rather have arch code do the bulk of that work, don't you think ? Which brings me back to this option, which may be the simplest and avoids the overhead of the proposed series (I found the series to be a nice cleanup but retpoline does kick us in the nuts here). So what about this ?--- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c@@ -155,7 +155,7 @@ static bool vring_use_dma_api(struct virtio_device*vdev) * the DMA API if we're a Xen guest, which at least allows * all of the sensible Xen configurations to work correctly. */ - if (xen_domain()) + if (xen_domain() || arch_virtio_direct_dma_ops(&vdev->dev)) return true; return false;
Right but can't we fix the retpoline overhead such that vring_use_dma_api will not be called on data path any longer, making this a setup time check?
(Passing the dev allows the arch to know this is a virtio device in "direct" mode or whatever we want to call the !iommu case, and construct appropriate DMA ops for it, which aren't the same as the DMA ops of any other PCI device who *do* use the iommu).
I think that's where Christoph might have specific ideas about it.
Otherwise, the harder option would be for us to hack so that xen_domain() returns true in our setup (gross), and have the arch code, when it sets up PCI device DMA ops, have a gross hack to identify virtio PCI devices, checks their F_IOMMU flag itself, and sets up the different ops at that point. As for those "special" ops, they are of course just normal swiotlb ops, there's nothing "special" other that they aren't the ops that other PCI device on that bus use. Cheers, Ben.
-- MST