Thread (1 message) 1 message, 1 author, 2018-07-31

Re: [PATCH net-next 1/2] virtio-net: correctly update XDP_TX counters

From: David Miller <davem@davemloft.net>
Date: 2018-07-31 17:03:20
Also in: lkml, netdev

From: Jason Wang <redacted>
Date: Tue, 31 Jul 2018 17:43:38 +0800
Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to
count TX XDP stats in virtnet_receive(). This will cause several
issues:

- virtnet_xdp_sq() was called without checking whether or not XDP is
  set. This may cause out of bound access when there's no enough txq
  for XDP.
- Stats were updated even if there's no XDP/XDP_TX.

Fixing this by reusing virtnet_xdp_xmit() for XDP_TX which can counts
TX XDP counter itself and remove the unnecessary tx stats embedded in
rx stats.

Reported-by: syzbot+604f8271211546f5b3c7@syzkaller.appspotmail.com
Fixes: 5b8f3c8d30a6 ("virtio_net: Add XDP related stats")
Cc: Toshiaki Makita <redacted>
Signed-off-by: Jason Wang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help