Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting
From: David Hildenbrand <hidden>
Date: 2018-06-29 16:03:21
Also in:
kvm, linux-mm, lkml
From: David Hildenbrand <hidden>
Date: 2018-06-29 16:03:21
Also in:
kvm, linux-mm, lkml
quoted
Why would your suggestion still be applicable? Your point for now is "I might not want to have page hinting enabled due to the overhead, but still a live migration speedup". If that overhead actually exists (we'll have to see) or there might be another reason to disable page hinting, then we have to decide if that specific setup is worth it merging your changes.All the above "if we have", "assume we have" don't sound like a valid argument to me.
Argument? *confused* And that hinders you from answering the question "Why would your suggestion still be applicable?" ? Well, okay. So I will answer it by myself: Because somebody would want to disable page hinting. Maybe there are some people out there.
quoted
I am not (and don't want to be) in the position to make any decisions here :) I just want to understand if two interfaces for free pages actually make sense.I responded to Nitesh about the differences, you may want to check with him about this. I would suggest you to send out your patches to LKML to get a discussion with the mm folks.
Indeed, Nitesh is trying to solve the problems we found in the RFC, so this can take some time.
Best, Wei
-- Thanks, David / dhildenb