Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

From
Ingo Molnar <mingo@kernel.org>
Date
2018-06-22 02:24:11
Also in
linux-efi, linux-kbuild, lkml
* Nick Desaulniers [off-list ref] wrote:

native_save_fl() is marked static inline, but by using it as
a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.
quoted hunk
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -13,7 +13,7 @@
  * Interrupt control:
  */
 
-static inline unsigned long native_save_fl(void)
+extern inline unsigned long native_save_fl(void)
 {
 	unsigned long flags;
 
What's the code generation effect of this on say a defconfig kernel vmlinux with 
paravirt enabled?

Thanks,

	Ingo
  






  

    
      Thread (1 message)
      
        1 message,
        1 author,
        last reply 2018-06-22
      
    
    
      
      
      
    
  

  

  
  




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread / next series-diff position

          
kprevious message in thread / previous series-diff position

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help