Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h>
From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2018-06-15 00:18:36
Also in:
linux-efi, linux-kbuild, lkml
Possibly related (same subject, not in this thread)
- 2018-06-21 · Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> · Ingo Molnar <mingo@kernel.org>
- 2018-06-14 · Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> · "H. Peter Anvin" <hpa@zytor.com>
On 06/14/18 13:59, Nick Desaulniers wrote:
On Thu, Jun 14, 2018 at 1:48 PM H. Peter Anvin [off-list ref] wrote:quoted
On 06/13/18 14:05, Nick Desaulniers wrote:quoted
From: "H. Peter Anvin" <redacted> i386 and x86-64 uses different registers for arguments; make them available so we don't have to #ifdef in the actual code. Native size and specified size (q, l, w, b) versions are provided. Suggested-by: Sedat Dilek <redacted> Signed-off-by: H. Peter Anvin <redacted> Signed-off-by: Nick Desaulniers <redacted>I still object to Suggested-by: here. Sedat did a correction, which is a Reviewed-by:, but unless I'm completely out to sea, there was no suggestion on Sedat's part of this; and I had certainly not seen it when I wrote the code.I'm fine with changing it from a Suggested-by to a Reviewed-by. Can you do that when you apply the set, or should I send a v6?
I'm not handling patch mechanics for x86 at the moment. -hpa