Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

On 06/05/18 10:52, Nick Desaulniers wrote:

Does the kernel have a different calling convention for 32b x86? How
does that work? regparm=3? Does that need to be added to the
declaration?

Yes, -mregparm=3.  No, doesn't need to be added to the declaration.

quoted

Something like this added to <asm/asm.h> might be useful; then you can
simply:

      push %_ASM_ARG1

Version with fixed typo...

Oh, nice, thanks! I'll pick this up and add it to my patch set for v3
(or did you want me to review/sign-off now?) I can pick up Sedat's
suggestion.

Add it to your patchset and add your own signoff underneath mine.

	-hpa