Thread (1 message) 1 message, 1 author, 2018-06-04

Re: [PATCH] drm/qxl: Call qxl_bo_unref outside atomic context

From: Gerd Hoffmann <kraxel@redhat.com>
Date: 2018-06-04 07:37:23

On Fri, Jun 01, 2018 at 04:05:32PM -0400, Jeremy Cline wrote:
"qxl_bo_unref" may sleep, but calling "qxl_release_map" causes
"preempt_disable()" to be called and "preempt_enable()" isn't called
until "qxl_release_unmap" is used. Move the call to "qxl_bo_unref" out
from in between the two to avoid sleeping from an atomic context.

This issue can be demonstrated on a kernel with CONFIG_LOCKDEP=y by
creating a VM using QXL, using a desktop environment using Xorg, then
moving the cursor on or off a window.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1571128
Fixes: 9428088c90b6 ("drm/qxl: reapply cursor after resetting primary")
Cc: stable@vger.kernel.org
Signed-off-by: Jeremy Cline <redacted>
Pushed to drm-misc-fixes.

thanks,
  Gerd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help