Re: [virtio-dev] Re: [PATCH v1] virtio: support VIRTIO_F_IO_BARRIER

On Thu, May 10, 2018 at 04:02:58PM +0100, Stefan Hajnoczi wrote:

On Thu, May 10, 2018 at 06:39:41PM +0800, Tiwei Bie wrote:

quoted

On Thu, May 10, 2018 at 10:53:17AM +0100, Stefan Hajnoczi wrote:

quoted

On Fri, May 04, 2018 at 12:59:15PM +0800, Tiwei Bie wrote:

quoted

diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
index 308e2096291f..9fb519a9df28 100644
--- a/include/uapi/linux/virtio_config.h
+++ b/include/uapi/linux/virtio_config.h

@@ -49,7 +49,7 @@
  * transport being used (eg. virtio_ring), the rest are per-device feature
  * bits. */
 #define VIRTIO_TRANSPORT_F_START	28
-#define VIRTIO_TRANSPORT_F_END		34
+#define VIRTIO_TRANSPORT_F_END		37

Have you updated "2.2 Feature Bits" in the VIRTIO spec?

In 1.0 it says:

 24 to 32
    Feature bits reserved for extensions to the queue and feature negotiation mechanisms

This information is out-of-date.

No. In the latest spec draft, it's 24 to 33. And it
becomes out-of-date since VIRTIO_F_RING_PACKED(34)
and VIRTIO_F_IN_ORDER(35) were introduced. Do you
want me to update it in the IO_BARRIER patch or do
you want me to update it in a new patch?

Please update it to 37 in the IO_BARRIER patch.

Will do it! Thanks!

Best regards,
Tiwei Bie