Re: [PATCH v2 21/27] x86/ftrace: Adapt function tracing for PIE support
From: Peter Zijlstra <peterz@infradead.org>
Date: 2018-03-14 10:35:37
Also in:
kvm, linux-arch, linux-crypto, linux-pm, lkml
On Tue, Mar 13, 2018 at 01:59:39PM -0700, Thomas Garnier wrote:
+ /* + * If PIE is not enabled or no GOT call was found, default to the + * original approach to code modification. + */ + if (!IS_ENABLED(CONFIG_X86_PIE) + || probe_kernel_read(replaced, (void *)ip, sizeof(replaced)) + || memcmp(replaced, got_call_preinsn, sizeof(got_call_preinsn))) + return ftrace_modify_code_direct(ip, old_code, new_code);
The predominant kernel style is to place the operators at the end of the previous line, not first on the new line.