Re: [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2017-12-22 09:06:41
Also in:
linux-arm-kernel, linux-crypto, lkml
Possibly related (same subject, not in this thread)
- 2017-12-22 · Re: [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests · Corentin Labbe <clabbe.montjoie@gmail.com>
- 2017-12-22 · Re: [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests · Herbert Xu <herbert@gondor.apana.org.au>
- 2017-12-07 · Re: [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests · Corentin Labbe <clabbe.montjoie@gmail.com>
- 2017-12-06 · Re: [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests · Fabien DESSENNE <hidden>
- 2017-11-29 · [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests · Corentin Labbe <clabbe.montjoie@gmail.com>
On Fri, Dec 22, 2017 at 09:41:48AM +0100, Corentin Labbe wrote:
It's you that was suggesting using crypto_async_request: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1474434.html "The only wart with this scheme is that the drivers end up seeing struct crypto_async_request and will need to convert that to the respective request types but I couldn't really find a better way." So I wait for any suggestion.
The core engine code obviously will use the base type but it should not be exposed to the driver authors. IOW all exposed API should take the final types such as aead_request before casting it. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt