Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-12-21 10:53:44
Subsystem:
the rest, virtio core · Maintainers:
Linus Torvalds, "Michael S. Tsirkin", Jason Wang
Possibly related (same subject, not in this thread)
- 2018-01-07 · [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all · Vincent Legoll <hidden>
- 2018-01-02 · Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all · Michael Ellerman <mpe@ellerman.id.au>
- 2017-12-22 · Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all · Michael Ellerman <mpe@ellerman.id.au>
- 2017-12-21 · Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all · Vincent Legoll <hidden>
- 2017-12-09 · [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all · Vincent Legoll <hidden>
Vincent Legoll [off-list ref] writes:
quoted hunk
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <redacted> --- drivers/virtio/Kconfig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index cff773f15b7e..d485a63a8233 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig@@ -5,7 +5,10 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -menu "Virtio drivers" +menuconfig VIRTIO_MENU + bool "Virtio drivers" + +if VIRTIO_MENU
This breaks all existing .configs *and* defconfigs that use VIRTIO. Please don't do that. If you make it default y then everything will continue to work. cheers
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index d485a63a8233..35897649c24f 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig@@ -7,6 +7,7 @@ config VIRTIO menuconfig VIRTIO_MENU bool "Virtio drivers" + default y if VIRTIO_MENU