Re: [PATCH v2] x86/paravirt: Don't make vcpu_is_preempted() a callee-save function

From
Peter Zijlstra <peterz@infradead.org>
Date
2017-02-13 10:54:09
Also in
kvm, linux-arch, lkml
Reply to
Peter Zijlstra, 2017-02-13
On Mon, Feb 13, 2017 at 11:47:16AM +0100, Peter Zijlstra wrote:
That way we'd end up with something like:

asm("
push %rdi;
movslq %edi, %rdi;
movq __per_cpu_offset(,%rdi,8), %rax;
cmpb $0, %[offset](%rax);
setne %al;
pop %rdi;
" : : [offset] "i" (((unsigned long)&steal_time) + offsetof(struct steal_time, preempted)));

And if we could get rid of the sign extend on edi we could avoid all the
push-pop nonsense, but I'm not sure I see how to do that (then again,
this asm foo isn't my strongest point).
Maybe:

movsql %edi, %rax;
movq __per_cpu_offset(,%rax,8), %rax;
cmpb $0, %[offset](%rax);
setne %al;

?
Thread (13 messages) 13 messages, 4 authors, last reply 2017-02-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help