Re: [PATCH v2 1/2] virtio_scsi: Add fc_host definitions
flat view
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2017-01-26 21:49:24
Also in:
linux-scsi, lkml
On Thu, Jan 26, 2017 at 11:41:08AM +0800, Fam Zheng wrote:
Signed-off-by: Fam Zheng <redacted> ---
I pefer combining this with implementation, hard to reason about interface alone.
quoted hunk
include/uapi/linux/virtio_scsi.h | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/include/uapi/linux/virtio_scsi.h b/include/uapi/linux/virtio_scsi.h index cc18ef8..a26fb31 100644 --- a/include/uapi/linux/virtio_scsi.h +++ b/include/uapi/linux/virtio_scsi.h@@ -113,6 +113,11 @@ struct virtio_scsi_config { __u16 max_channel; __u16 max_target; __u32 max_lun; + __u8 primary_wwpn[8]; + __u8 primary_wwnn[8]; + __u8 secondary_wwpn[8]; + __u8 secondary_wwnn[8]; + __u8 primary_active;
Is this in fact a binary value? Also pls add padding to align on 8 byte boundary.
quoted hunk
} __attribute__((packed)); /* Feature Bits */@@ -120,6 +125,7 @@ struct virtio_scsi_config { #define VIRTIO_SCSI_F_HOTPLUG 1 #define VIRTIO_SCSI_F_CHANGE 2 #define VIRTIO_SCSI_F_T10_PI 3 +#define VIRTIO_SCSI_F_FC_HOST 4 /* Response codes */ #define VIRTIO_SCSI_S_OK 0-- 2.9.3