Re: [PATCH 10/10] virtio: enable endian checks for sparse builds
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-12-07 06:26:41
Also in:
dri-devel, kvm, linux-crypto, linux-kbuild, linux-remoteproc, linux-s390, linux-scsi, lkml, netdev
On Tue, 2016-12-06 at 17:41 +0200, Michael S. Tsirkin wrote:
It seems that there should be a better way to do it, but this works too.
In some cases there might be:
quoted hunk
--- a/drivers/s390/virtio/Makefile +++ b/drivers/s390/virtio/Makefile@@ -6,6 +6,8 @@# it under the terms of the GNU General Public License (version 2 only) # as published by the Free Software Foundation. +CFLAGS_virtio_ccw.o += -D__CHECK_ENDIAN__ +CFLAGS_kvm_virtio.o += -D__CHECK_ENDIAN__ s390-virtio-objs := virtio_ccw.o ifdef CONFIG_S390_GUEST_OLD_TRANSPORT s390-virtio-objs += kvm_virtio.o
Here you could use ccflags-y += -D__CHECK_ENDIAN__ for example, or even subdir-ccflags-y += -D__CHECK_ENDIAN__ (in case any subdirs ever get added here)
quoted hunk
--- a/drivers/vhost/Makefile +++ b/drivers/vhost/Makefile@@ -1,3 +1,4 @@ +ccflags-y := -D__CHECK_ENDIAN__
Looks like you did that here and in some other places though - so perhaps the s390 one was intentionally different?
quoted hunk
--- a/net/packet/Makefile +++ b/net/packet/Makefile@@ -2,6 +2,7 @@# Makefile for the packet AF. # +ccflags-y := -D__CHECK_ENDIAN__
Technically this is slightly more than advertised, but I guess that still makes sense if it's clean now. johannes _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization