Thread (1 message) flat view 1 message, 1 author, 2016-12-07

Re: [PATCH 02/10] drm/virtio: fix endianness in primary_plane_update

From: Jason Wang <hidden>
Date: 2016-12-07 04:13:56
Also in: dri-devel, lkml


On 2016年12月06日 23:40, Michael S. Tsirkin wrote:
virtio_gpu_cmd_transfer_to_host_2d expects x and y
parameters in LE, but virtio_gpu_primary_plane_update
passes in the CPU format instead.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
  drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Jason Wang <redacted>
quoted hunk
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index ba28c0f..1fda965 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -88,8 +88,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane *plane,
  				(vgdev, handle, 0,
  				 cpu_to_le32(plane->state->src_w >> 16),
  				 cpu_to_le32(plane->state->src_h >> 16),
-				 plane->state->src_x >> 16,
-				 plane->state->src_y >> 16, NULL);
+				 cpu_to_le32(plane->state->src_x >> 16),
+				 cpu_to_le32(plane->state->src_y >> 16), NULL);
  		}
  	} else {
  		handle = 0;
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help