Regards,
-Gonglei
-----Original Message-----
From: <redacted>
[mailto:linux-crypto-owner@vger.kernel.org] On Behalf Of Sam Ravnborg
Sent: Saturday, December 10, 2016 5:59 AM
To: Gonglei (Arei)
Cc: <redacted>; <redacted>;
virtio-dev@lists.oasis-open.org; virtualization@lists.linux-foundation.org;
linux-crypto@vger.kernel.org; Luonengjun; mst@redhat.com;
stefanha@redhat.com; Huangweidong (C); Wubin (H); xin.zeng@intel.com;
Claudio Fontana; herbert@gondor.apana.org.au; pasic@linux.vnet.ibm.com;
davem@davemloft.net; Zhoujian (jay, Euler); Hanweidong (Randy);
arei.gonglei@hotmail.com; cornelia.huck@de.ibm.com; Xuquan (Quan Xu);
longpeng; Wanzongshun (Vincent); sparclinux@vger.kernel.org
Subject: Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild
Hi Gonglei.
On Thu, Dec 08, 2016 at 12:37:08PM +0800, Gonglei wrote:
quoted
quoted
quoted
arch/sparc/include/asm/topology_64.h:44:44:
error: implicit declaration of function 'cpu_data'
[-Werror=implicit-function-declaration]
#define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
^
Let's include cpudata.h in topology_64.h.
Cc: Sam Ravnborg <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: <redacted>
Suggested-by: Sam Ravnborg <redacted>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Acked-by: Sam Ravnborg <redacted>
Thanks.
quoted
---
arch/sparc/include/asm/topology_64.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sparc/include/asm/topology_64.h
b/arch/sparc/include/asm/topology_64.h
quoted
index 7b4898a..2255430 100644
--- a/arch/sparc/include/asm/topology_64.h
+++ b/arch/sparc/include/asm/topology_64.h
@@ -4,6 +4,7 @@
#ifdef CONFIG_NUMA
#include <asm/mmzone.h>
+#include <asm/cpudata.h>
Nitpick - if you are going to resend this patch,
It depends on the maintainer's thought. :)
then please order the two includes in alphabetic order.
For two includes this looks like bikeshedding, but when we add
more having them in a defined arder prevents merge conflicts.
And makes it readable too.
We also sometimes order the includes with the longest lines topmost,
and lines with the ame length are ordered alphabetically.
But this is not seen so often.
Regards,
-Gonglei