Re: [PATCH 1/3] tools/virtio: fix READ_ONCE()

From
Jason Wang <hidden>
Date
2016-11-25 02:39:06
Also in
kvm, lkml, netdev

On 2016年11月24日 18:25, Mark Rutland wrote:
quoted hunk
The virtio tools implementation of READ_ONCE() has a single parameter called
'var', but erroneously refers to 'val' for its cast, and thus won't work unless
there's a variable of the correct type that happens to be called 'var'.

Fix this with s/var/val/, making READ_ONCE() work as expected regardless.

Fixes: a7c490333df3cff5 ("tools/virtio: use virt_xxx barriers")
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Jason Wang <redacted>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: <redacted>
Cc: <redacted>
---
  tools/virtio/linux/compiler.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtio/linux/compiler.h b/tools/virtio/linux/compiler.h
index 845960e..c9ccfd4 100644
--- a/tools/virtio/linux/compiler.h
+++ b/tools/virtio/linux/compiler.h
@@ -4,6 +4,6 @@
  #define WRITE_ONCE(var, val) \
  	(*((volatile typeof(val) *)(&(var))) = (val))
  
-#define READ_ONCE(var) (*((volatile typeof(val) *)(&(var))))
+#define READ_ONCE(var) (*((volatile typeof(var) *)(&(var))))
  
  #endif
Reviewed-by: Jason Wang <redacted>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Thread (1 message) 1 message, 1 author, last reply 2016-11-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help