Re: [PATCH 1/3] tools/virtio: fix READ_ONCE()

Started by Cornelia Huck on Nov 24, 2016

open the first message on its own page

Message details and related content
On Thu, 24 Nov 2016 10:25:12 +0000
Mark Rutland [off-list ref] wrote:
The virtio tools implementation of READ_ONCE() has a single parameter called
'var', but erroneously refers to 'val' for its cast, and thus won't work unless
there's a variable of the correct type that happens to be called 'var'.

Fix this with s/var/val/, making READ_ONCE() work as expected regardless.

Fixes: a7c490333df3cff5 ("tools/virtio: use virt_xxx barriers")
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Jason Wang <redacted>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: <redacted>
Cc: <redacted>
---
 tools/virtio/linux/compiler.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help