Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver
From: Kees Cook <hidden>
Date: 2016-09-08 20:50:03
Also in:
kvm, lkml, qemu-devel
On Sun, Sep 4, 2016 at 7:38 AM, Namhyung Kim [off-list ref] wrote:
The virtio pstore driver provides interface to the pstore subsystem so that the guest kernel's log/dump message can be saved on the host machine. Users can access the log file directly on the host, or on the guest at the next boot using pstore filesystem. It currently deals with kernel log (printk) buffer only, but we can extend it to have other information (like ftrace dump) later. It supports legacy PCI device using a 16K buffer by default and it's configurable. It uses two virtqueues - one for (sync) read and another for (async) write. Since it cannot wait for write finished, it supports up to 128 concurrent IO. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Radim Krčmář <redacted> Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Anthony Liguori <redacted> Cc: Anton Vorontsov <redacted> Cc: Colin Cross <redacted> Cc: Kees Cook <redacted> Cc: Tony Luck <tony.luck@intel.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Minchan Kim <minchan@kernel.org> Cc: Will Deacon <redacted> Cc: virtio-dev@lists.oasis-open.org Cc: kvm@vger.kernel.org Cc: qemu-devel@nongnu.org Cc: virtualization@lists.linux-foundation.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
While I can't speak to the virtio parts, the interface into pstore looks fine to me. :) Reviewed-by: Kees Cook <redacted> -Kees -- Kees Cook Nexus Security _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization