Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets

Hi Bjorn

On 09/13/2016 08:06 PM, Bjorn Andersson wrote:

On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote:

quoted

Hi Vinod & Bjorn,

[..]

On Mon, 05 Sep 2016, Peter Griffin wrote:

quoted

v8 actions some review feedback from Bjorn to the slim rproc driver, and also includes
a patch which fixes a recursive Kconfig error which is triggered when st_fdma selects
slim_rproc driver. The series has also been rebased on v4.8-rc3.

v9 actions some review feedback from Bjorn, Lee and Vinod. See below. Importantly a bug
was found during testing now that the platform boots without clk_ignore_unused parameter
whereby the clocks would not be enabled properly before firmware loading was attempted.

regards,

Peter.

Changes since v8:
 - Add MODULE_ALIAS (Vinod)
 - devm_kzalloc to devm_kcalloc (Vinod)
 - quisce tasklet initialised by vchan_init() (Vinod)
 - Don't make SLIM rproc user selectable (Bjorn)
 - slim_rproc: Ensure clocks enabled before firmware load (Peter)
 - Various code style nits / commit message change (Lee)
 - Separate patch for '\n' kconfig removal (Vinod)

I hate to send a ping,

Sorry about that.

quoted

but do you think we can merge this fdma series? It has gone
through quite a few review rounds now.

I think the remoteproc part looks good.

Vinod, I don't have any changes queued in remoteproc that should cause
merge issues. If you want to you could take the remoteproc patch
through your tree.


I do however think that the dts patches should go through arm-soc.

I will take care about dts patches by adding them in the next STi DT pull request

Thanks
Patrice

Regards,
Bjorn