On Wed, 06/29 23:38, Christoph Hellwig wrote:

On Thu, Jun 30, 2016 at 02:35:54PM +0800, Fam Zheng wrote:

quoted

also more code and less flexible IMO.  For example, we need at least two
variants, for attribute_group and device_attribute separately, right?

Yes, or maybe just a calling convention that just passes both.

OK, I can look into that, but I'm not sure about the error handling. Currently
add_disk returns void, do you have any plan on that too? should I change it in
v3 (to at least return the attribute creation failure)?

Fam