Thread (4 messages) 4 messages, 4 authors, 2016-08-04

Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

From: Cornelia Huck <hidden>
Date: 2016-07-19 12:22:43

On Tue, 19 Jul 2016 12:32:42 +0800
Minfei Huang [off-list ref] wrote:
From: Minfei Huang <redacted>

We do a lot of memory allocation in function init_vq, and don't handle
the allocation failure properly. Then this function will return 0,
although initialization fails due to lacking memory. At that moment,
kernel will panic in guest machine, if virtio is used to drive disk.

To fix this bug, we should take care of allocation failure, and return
correct value to let caller know what happen.

Tested-by: Chao Fan <redacted>
Signed-off-by: Minfei Huang <redacted>
Signed-off-by: Minfei Huang <redacted>
---
v2:
- Remove useless initialisation to NULL
v1:
- Refactor the patch to make code more readable
---
 drivers/block/virtio_blk.c | 26 ++++++++------------------
 1 file changed, 8 insertions(+), 18 deletions(-)
Your changes certainly make the function more compact.

Reviewed-by: Cornelia Huck <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help