Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code
From: Cornelia Huck <hidden>
Date: 2016-02-10 13:24:59
Also in:
kvm, lkml, netdev
Possibly related (same subject, not in this thread)
- 2016-02-10 · Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code · "Michael S. Tsirkin" <mst@redhat.com>
- 2016-01-21 · Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code · Cornelia Huck <hidden>
- 2016-01-13 · [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code · Greg Kurz <hidden>
On Wed, 10 Feb 2016 14:08:43 +0100 Greg Kurz [off-list ref] wrote:
But you are right, there is a bug: we should rollback if vhost_init_used()
fails. Something like below:
err_used:
vq->private_data = oldsock;
vhost_net_enable_vq(n, vq);
+ vhost_adjust_vring_endian(vq);Shouldn't we switch back before we reenable? Or have I lost myself in this maze here again?
if (ubufs)
vhost_net_ubuf_put_wait_and_free(ubufs);
err_ubufs: