Re: [PATCH v5 00/10] virtio DMA API, yet again

From
Andy Lutomirski <luto@amacapital.net>
Date
2016-01-31 20:16:18
On Sun, Jan 31, 2016 at 12:12 PM, Michael S. Tsirkin [off-list ref] wrote:
On Thu, Jan 28, 2016 at 06:31:13PM -0800, Andy Lutomirski wrote:
quoted
This switches virtio to use the DMA API on Xen and if requested by
module option.

This fixes virtio on Xen, and it should break anything because it's
off by default on everything except Xen PV on x86.

To the Xen people: is this okay?  If it doesn't work on other Xen
variants (PVH? HVM?), can you submit follow-up patches to fix it?

To everyone else: we've waffled on this for way too long.  I think
we should to get DMA API implementation in with a conservative
policy like this rather than waiting until we achieve perfection.
I'm tired of carrying these patches around.
I agree, thanks for working on this!
quoted
Michael, if these survive review, can you stage these in your tree?
Yes, I'll stage everything except 10/10. I'd rather not maintain a
module option like this, things work for now and I'm working on a
clean solution for things like dpdk within guest.
The module option was mainly for testing, but patching in a "return
true" works just as well.

I ran the code through the DMA API debugging stuff and swiotlb=force
with the module option set under KVM (no Xen), and everything seemed
to work.

--Andy
Thread (1 message) 1 message, 1 author, last reply 2016-01-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help