Re: [PATCH] vhost: vsock: select CONFIG_VHOST

From
David Miller <davem@davemloft.net>
Date
2015-12-08 17:13:59
Also in
kvm, lkml, netdev
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 8 Dec 2015 18:09:44 +0200
On Tue, Dec 08, 2015 at 04:46:08PM +0100, Arnd Bergmann wrote:
quoted
When building the new vsock code without vhost, we get a build error:

drivers/built-in.o: In function `vhost_vsock_flush':
:(.text+0x24d29c): undefined reference to `vhost_poll_flush'

This adds an explicit 'select' like we have for the other vhost
drivers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This will need to be done eventually, so

Acked-by: Michael S. Tsirkin <mst@redhat.com>

but I really think the right thing for now is to revert current vsock
code, or disable building it unconditionally.  Stefan, could you please
send a patch like this?
I'm waiting for the full single revert patch and will apply it as
soon as I receive it.
Thread (1 message) 1 message, 1 author, last reply 2015-12-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help