Re: [PATCH v3 0/3] virtio DMA API core stuff
flat view
From: David Woodhouse <dwmw2@infradead.org>
Date: 2015-10-28 06:53:31
Also in:
kvm, linux-s390, lkml
On Tue, 2015-10-27 at 23:38 -0700, Andy Lutomirski wrote:
Changes from v2: - Fix really embarrassing bug. This version actually works.
So embarrassing you didn't want to tell us what it was? ...
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c@@ -292,7 +292,7 @@ static inline int virtqueue_add(struct virtqueue *_vq, vq, desc, total_sg * sizeof(struct vring_desc), DMA_TO_DEVICE); - if (vring_mapping_error(vq, vq->vring.desc[head].addr)) + if (vring_mapping_error(vq, addr)) goto unmap_release; vq->vring.desc[head].flags = cpu_to_virtio16(_vq->vdev, VRING_DESC_F_INDIRECT);
That wasn't going to be the reason for Christian's failure, was it? -- dwmw2