Re: [PATCH] vhost: fix performance on LE hosts

Started by Michael S. Tsirkin on Oct 27, 2015

open the first message on its own page

Message details and related content
On Tue, Oct 27, 2015 at 06:32:55AM -0700, David Miller wrote:
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 27 Oct 2015 11:37:39 +0200
quoted
commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian
support for legacy devices") introduced a minor regression: even with
cross-endian disabled, and even on LE host, vhost_is_little_endian is
checking is_le flag so there's always a branch.

To fix, simply check virtio_legacy_is_little_endian first.

Cc: Greg Kurz <redacted>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Michael, do you want me to take this via the 'net' tree?
Sure - especially since it looks like I have nothing else for this merge
window (working on fixing shutdown races, but it's slow going).  Thanks
a lot!

-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help