Re: [virtio-dev] Re: [PATCH v5] Add virtio-input driver.

Started by Michael S. Tsirkin on Mar 28, 2015

open the first message on its own page

Message details and related content
On Thu, Mar 26, 2015 at 01:10:40PM +0100, Michael S. Tsirkin wrote:
On Thu, Mar 26, 2015 at 11:49:25AM +0100, Gerd Hoffmann wrote:
quoted
virtio-input is basically evdev-events-over-virtio, so this driver isn't
much more than reading configuration from config space and forwarding
incoming events to the linux input layer.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Still a bit worried about using input.h as host/guest
interface (can't we use some formal standard, e.g. USB HID?),
but I'll let Rusty decide that.

Otherwise mostly looks good. One nit below.
Forgot to include:
Acked-by: Michael S. Tsirkin <mst@redhat.com>

quoted
---
Could you pls include changelog in the future?
You are sending multiple versions per day and it's hard to keep up.
quoted
+static unsigned int features[] = {
+	/* none */
+};
An empty line wouldn't hurt here about variable definition.
quoted
+static struct virtio_device_id id_table[] = {
+	{ VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID },
+	{ 0 },
+};
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help