Re: [PATCH 8/9] virtio_pci: split out legacy device support
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2014-12-16 22:55:42
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2014-12-08 · [PATCH 8/9] virtio_pci: split out legacy device support · "Michael S. Tsirkin" <mst@redhat.com>
On Wed, Dec 17, 2014 at 08:03:10AM +1100, Herbert Xu wrote:
Michael S. Tsirkin [off-list ref] wrote:quoted
Move everything dealing with legacy devices out to virtio_pci_legacy.c. Expose common code APIs in virtio_pci.h Signed-off-by: Michael S. Tsirkin <mst@redhat.com>This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the virtio_pci driver was moved into virtio_pci_legacy.c the module licence and other attributes went AWOL. This patch restores them. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks! I'll apply a similar patch but to virtio_pci_common. Will send a pull request with this included tomorrow.
quoted hunk ↗ jump to hunk
diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 2588252..6b100e3 100644 --- a/drivers/virtio/virtio_pci_legacy.c +++ b/drivers/virtio/virtio_pci_legacy.c@@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = { }; module_pci_driver(virtio_pci_driver); + +MODULE_AUTHOR("Anthony Liguori <aliguori@us.ibm.com>"); +MODULE_DESCRIPTION("virtio-pci"); +MODULE_LICENSE("GPL"); +MODULE_VERSION("1");Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt