Re: [PATCH v7 31/46] vhost: virtio 1.0 endian-ness support
From: Cornelia Huck <hidden>
Date: 2014-12-01 12:43:01
Also in:
kvm, lkml, netdev
On Mon, 1 Dec 2014 14:37:01 +0200 "Michael S. Tsirkin" [off-list ref] wrote:
On Mon, Dec 01, 2014 at 01:33:53PM +0100, Cornelia Huck wrote:quoted
On Sun, 30 Nov 2014 17:11:49 +0200 "Michael S. Tsirkin" [off-list ref] wrote:quoted
Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/vhost/vhost.c | 93 +++++++++++++++++++++++++++++++-------------------- 1 file changed, 56 insertions(+), 37 deletions(-)quoted
@@ -1113,18 +1120,19 @@ static int get_indirect(struct vhost_virtqueue *vq, { struct vring_desc desc; unsigned int i = 0, count, found = 0; + u32 len = vhost32_to_cpu(vq, indirect->len); int ret; /* Sanity check */ - if (unlikely(indirect->len % sizeof desc)) { + if (unlikely(len % sizeof desc)) { vq_err(vq, "Invalid length in indirect descriptor: " "len 0x%llx not multiple of 0x%zx\n", - (unsigned long long)indirect->len, + (unsigned long long)vhost32_to_cpu(vq, indirect->len),Can't you use len here?Not if I want error message to be readable.
Huh? Both have the same value.