Re: [PATCH v4 18/42] virtio_blk: make serial attribute static
From: Cornelia Huck <hidden>
Date: 2014-11-26 09:50:45
Also in:
lkml
On Tue, 25 Nov 2014 18:42:42 +0200 "Michael S. Tsirkin" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
It's never declared so no need to make it extern. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/block/virtio_blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index f601f16..055f3df 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c@@ -332,7 +332,8 @@ static ssize_t virtblk_serial_show(struct device *dev, return err; } -DEVICE_ATTR(serial, S_IRUGO, virtblk_serial_show, NULL); + +static DEVICE_ATTR(serial, S_IRUGO, virtblk_serial_show, NULL); static void virtblk_config_changed_work(struct work_struct *work) {
The virtio-blk attributes might benefit from a conversion to attribute groups (which support masking and so on), but that's a different cleanup. So, fwiw: Acked-by: Cornelia Huck <redacted>