[3.16 stable PATCH 2/2] virtio-rng: skip reading when we start to remove the device
From: Amos Kong <hidden>
Date: 2014-10-10 22:52:06
Also in:
lkml, stable
Subsystem:
hardware random number generator core, the rest · Maintainers:
Olivia Mackall, Herbert Xu, Linus Torvalds
Before we really unregister the hwrng device, reading will get stuck if the virtio device is reset. We should return error for reading when we start to remove the device. Signed-off-by: Amos Kong <redacted> Reviewed-by: Amit Shah <redacted> Cc: stable@vger.kernel.org Signed-off-by: Rusty Russell <redacted> (cherry picked from commit f49819560f53b7f3a596a8ea2e6764dc86695b62) Signed-off-by: Amos Kong <redacted> --- drivers/char/hw_random/virtio-rng.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
index b50252c..cb1688a 100644
--- a/drivers/char/hw_random/virtio-rng.c
+++ b/drivers/char/hw_random/virtio-rng.c@@ -37,6 +37,7 @@ struct virtrng_info { char name[25]; int index; bool hwrng_register_done; + bool hwrng_removed; };
@@ -69,6 +70,9 @@ static int virtio_read(struct hwrng *rng, void *buf, size_t size, bool wait) int ret; struct virtrng_info *vi = (struct virtrng_info *)rng->priv; + if (vi->hwrng_removed) + return -ENODEV; + if (!vi->busy) { vi->busy = true; init_completion(&vi->have_data);
@@ -137,6 +141,7 @@ static void remove_common(struct virtio_device *vdev) { struct virtrng_info *vi = vdev->priv; + vi->hwrng_removed = true; vi->data_avail = 0; complete(&vi->have_data); vdev->config->reset(vdev);
--
1.9.3