Re: [PATCH v2 03/15] virtio-pci: move freeze/restore to virtio core
From: Cornelia Huck <hidden>
Date: 2014-10-06 15:21:07
Also in:
kvm, lkml
On Mon, 6 Oct 2014 18:10:51 +0300 "Michael S. Tsirkin" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This is in preparation to extending config changed event handling in core. Wrapping these in an API also seems to make for a cleaner code. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- include/linux/virtio.h | 6 +++++ drivers/virtio/virtio.c | 53 +++++++++++++++++++++++++++++++++++++++++++ drivers/virtio/virtio_pci.c | 55 ++------------------------------------------- 3 files changed, 61 insertions(+), 53 deletions(-)diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 3c19bd3..8df7ba8 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h@@ -78,6 +78,7 @@ bool virtqueue_is_broken(struct virtqueue *vq); /** * virtio_device - representation of a device using virtio * @index: unique position on the virtio bus + * @failed: saved value for CONFIG_S_FAILED bit (for restore)
Have you considered s/failed/saved_failed/ ?
* @dev: underlying device. * @id: the device type identification (used to match it with a driver). * @config: the configuration ops for this device.
Otherwise, my Reviewed-by: Cornelia Huck <redacted> still stands.