Thread (4 messages) flat view 4 messages, 2 authors, 2014-07-28

Re: [PATCH] x86, paravirt: BUG_ON on {rd,wr}msr exceptions

From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2014-07-28 19:18:49
Also in: lkml

On 07/28/2014 12:04 PM, Eduardo Habkost wrote:
When CONFIG_PARAVIRT is enabled, the kernel is ignoring exceptions on
the {rd,wr}msr instructions. This makes serious issues (either on the
guest kernel, or on the host) be silently ignored, and is different from
the native MSR code (which does not ignore the exceptions).

As paravirt.h already includes linux/bug.h, I don't see what was the
original issue preventing BUG_ON from being used.

Change rdmsr(), wrmsr(), and rdmsrl() to BUG_ON() on errors.
How much does this bloat the kernel?

#include <stdparavirtrant.h>

	-hpa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help