Thread (13 messages) flat view 13 messages, 4 authors, 2014-07-23

Re: [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready

From: Rusty Russell <hidden>
Date: 2014-07-23 05:56:36
Also in: lkml

Amit Shah [off-list ref] writes:
On (Mon) 21 Jul 2014 [17:15:51], Amit Shah wrote:
quoted
Instead of calling hwrng_register() in the probe routing, call it in the
scan routine.  This ensures that when hwrng_register() is successful,
and it requests a few random bytes to seed the kernel's pool at init,
we're ready to service that request.

This will also enable us to remove the workaround added previously to
check whether probe was completed, and only then ask for data from the
host.  The revert follows in the next commit.

There's a slight behaviour change here on unsuccessful hwrng_register().
Previously, when hwrng_unregister() failed, the probe() routine would
typo: should be hwrng_register().

Please fix this up when picking up the patch.
Done.

All 4 patches applied!
Rusty.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help