Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
From: Greg KH <hidden>
Date: 2014-07-18 16:44:14
Also in:
dri-devel, linux-can, linux-crypto, linux-fbdev, linux-mips, linux-mmc, linux-pci, linux-rdma, linux-scsi, linux-wireless, lkml, netdev, platform-driver-x86
Possibly related (same subject, not in this thread)
- 2014-07-22 · Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use · Benoit Taine <hidden>
- 2014-07-21 · Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use · Bjorn Helgaas <bhelgaas@google.com>
- 2014-07-21 · Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use · David Miller <davem@davemloft.net>
- 2014-07-18 · Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use · Greg KH <hidden>
- 2014-07-18 · Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use · Dave Airlie <airlied@gmail.com>
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:quoted
We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch.Honestly, I prefer the macro -- it stands-out more. Maybe the style guidelines and/or checkpatch should change instead?
The macro is horrid, no other bus has this type of thing just to save a few characters in typing, so why should PCI be "special" in this regard anymore? thanks, greg k-h